Skip to content

feat(sdk-core): add VaultConfig types and defiParams to BuildParams/SendManyOptions#9205

Closed
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
masterfrom
venkatesh/defi-279-deposittovault-getvaultconfig-pt1
Closed

feat(sdk-core): add VaultConfig types and defiParams to BuildParams/SendManyOptions#9205
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
masterfrom
venkatesh/defi-279-deposittovault-getvaultconfig-pt1

Conversation

@bitgo-ai-agent-dev

@bitgo-ai-agent-dev bitgo-ai-agent-dev Bot commented Jul 8, 2026

Copy link
Copy Markdown

What

  • Add `GetVaultConfigOptions`, `VaultProvider`, `VaultConfig`, `ConcreteVaultConfig`, `ConcreteDepositResult` types to `iDefiVault.ts`
  • Update `DepositResult` to a discriminated union: `{ pendingApprovalId, state }` (concrete_btccx) | `{ operationId, txRequestIds }` (morpho)
  • Add `getVaultConfig` to the `IDefiVault` interface
  • Add `defiParams: t.unknown` to the `BuildParams` whitelist so the field passes through `prebuildWhitelistedParams()`
  • Add optional `defiParams` field to `SendManyOptions` for discoverability
  • Bump `@bitgo/public-types` to `^6.39.0` (picks up `defiParams` on `TxSendBody`)

Why

  • CB-1.8 requires `depositToVault` to support Concrete BTCcx vaults in addition to Morpho. Resolving the provider from vault config requires a new `getVaultConfig` method and new types for the Concrete response shape (a `pendingApproval`, not a txRequest)
  • `defiParams` must be whitelisted in `BuildParams` or it gets stripped by `prebuildWhitelistedParams()` before reaching WP

Test plan

  • Build passes: `yarn build` in `modules/sdk-core`
  • No TypeScript errors on the changed files

Stack

This PR is part 1 of 2 in a stack. Review and merge in order:

  1. feat(sdk-core): add VaultConfig types and defiParams to BuildParams/SendManyOptions #9205 — types + interfaces + dependency bump (base: `master`) ← you are here
  2. feat(sdk-core): add getVaultConfig and Concrete BTC deposit path to DefiVault #9206 — core logic + tests (base: `pt1`)

Ticket: DEFI-279

…endManyOptions

Part 1 of 2 for DEFI-279 (CB-1.8). Types + interfaces + dependency bump:

- Add GetVaultConfigOptions, VaultProvider, VaultConfig, ConcreteVaultConfig,
  ConcreteDepositResult to iDefiVault.ts; update DepositResult to a
  discriminated union (concrete_btccx pendingApproval | morpho operationId);
  add getVaultConfig to IDefiVault interface
- Add defiParams: t.unknown to BuildParams whitelist so it passes through
  prebuildWhitelistedParams() without being stripped
- Add optional defiParams field to SendManyOptions for discoverability
- Bump @bitgo/public-types to ^6.39.0 (picks up defiParams on TxSendBody)

Ticket: DEFI-279
Session-Id: ba171a5f-3d3c-4505-9e87-8df8afe5d59f
Task-Id: bffe5f00-9f9c-4882-be0f-d620f6eba4c5
@linear-code

linear-code Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

DEFI-279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant